qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error


From: Peter Xu
Subject: Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error
Date: Thu, 4 Jan 2018 10:18:45 +0800
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Jan 03, 2018 at 01:31:01PM +0100, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > It should be called in migrate_fd_cleanup too.
> 
> It is *already* called in migrate_fd_cleanup.
> 
> I think we should add a comment stating that we _always_ end calling
> migrate_fd_cleanup, independently of how the migration ends.
> 
> 
> > Signed-off-by: Peter Xu <address@hidden>
> 
> Reviewed-by: Juan Quintela <address@hidden>
> 
> I can also fix the comment when pulling if you agree with the change.

Yes.  Please modify according to your suggestions (including the other
patch comment).  Thanks for that!

-- 
Peter Xu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]