[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0 |
Date: |
Tue, 2 Jan 2018 18:58:19 +0100 |
On Tue, Jan 2, 2018 at 6:33 PM, Paolo Bonzini <address@hidden> wrote:
> On 02/01/2018 16:49, Marc-André Lureau wrote:
>> Hi
>>
>> On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake <address@hidden> wrote:
>>> On 12/15/2017 09:06 AM, Marc-André Lureau wrote:
>>>>
>>>> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu
>>>> specific).
>>>>
>>>> Use --quiet to silence make 'is up to date' message.
>>>>
>>>> Signed-off-by: Marc-André Lureau <address@hidden>
>>>> ---
>>>> Makefile | 2 +-
>>>> rules.mak | 2 ++
>>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>>
>>> Tested-by: Eric Blake <address@hidden>
>>>
>>> I'd still like a second opinion from another make expert (Paolo?) on whether
>>> this makes sense. Thus, even though it looks sane to me, I'm not (yet)
>>> giving R-b.
>>>
>>
>> Paolo, what do you think?
>
> Sounds good to me.
Thanks, I assume I can add your review-by to the patch.
--
Marc-André Lureau