[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 34/38] target/hppa: Only use EXCP_DTLB_MISS
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 34/38] target/hppa: Only use EXCP_DTLB_MISS |
Date: |
Thu, 28 Dec 2017 22:31:41 -0800 |
Unknown why this works, but if we return EXCP_ITLB_MISS we
will triple-fault the first userland instruction fetch.
Is it something to do with having a combined I/DTLB?
Signed-off-by: Richard Henderson <address@hidden>
---
target/hppa/mem_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index e2f94faab5..a0a385cb54 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -97,7 +97,9 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr,
int mmu_idx,
if (ent == NULL || !ent->entry_valid) {
phys = 0;
prot = 0;
- ret = (ifetch ? EXCP_ITLB_MISS : EXCP_DTLB_MISS);
+ /* ??? Unconditionally report data tlb miss,
+ even if this is an instruction fetch. */
+ ret = EXCP_DTLB_MISS;
goto egress;
}
--
2.14.3
- [Qemu-devel] [PATCH 27/38] target/hppa: Implement SYNCDMA insn, (continued)
- [Qemu-devel] [PATCH 27/38] target/hppa: Implement SYNCDMA insn, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 26/38] target/hppa: Implement LCI, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 31/38] target/hppa: Add system registers to gdbstub, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 32/38] target/hppa: Add migration for the cpu, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 29/38] hw/hppa: Implement DINO system board, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 30/38] target/hppa: Optimize for flat addressing space, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 33/38] target/hppa: Implement B,GATE insn, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 34/38] target/hppa: Only use EXCP_DTLB_MISS,
Richard Henderson <=
- [Qemu-devel] [PATCH 36/38] target/hppa: Use MMU_DEBUG_LOAD when reloading for CR[IIR], Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 37/38] target/hppa: Increase number of temp regs, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 38/38] target/hppa: Fix comment, Richard Henderson, 2017/12/29