Re: [Qemu-devel] [PULL v3 00/35] Block layer patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v3 00/35] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2c6e398f66 block: Keep nodes drained between reopen_queue/multiple
54e29ec0a5 commit: Simplify reopen of base
3a7e577b17 test-bdrv-drain: Test graph changes in drained section
848490206c block: Allow graph changes in subtree drained section
bd46aacb6b test-bdrv-drain: Recursive draining with multiple parents
fb4905fc4c test-bdrv-drain: Test behaviour in coroutine context
03d1e96448 test-bdrv-drain: Tests for bdrv_subtree_drain
34bb4a7adc block: Add bdrv_subtree_drained_begin/end()
f0d1a3dc3f block: Don't notify parents in drain call chain
69fa9fab43 test-bdrv-drain: Test nested drain sections
e0aeee3513 block: Nested drain_end must still call callbacks
ed5226abd8 block: Don't block_job_pause_all() in bdrv_drain_all()
c4c8c77428 test-bdrv-drain: Test drain vs. block jobs
27b8aa5dfc blockjob: Pause job on draining any job BDS
a83d97d2bb test-bdrv-drain: Test bs->quiesce_counter
56e27ec29e test-bdrv-drain: Test callback for bdrv_drain
51d5f59274 block: Make bdrv_drain() driver callbacks non-recursive
1619522c7c block: Assert drain_all is only called from main AioContext
4d1dfa60ee block: Remove unused bdrv_requests_pending
d2539f5797 block: Mention -drive cyls/heads/secs/trans/serial/addr in 
deprecation chapter
6554e2bdfa block: Remove the deprecated -hdachs option
9a8be0160c block: Remove the obsolete -drive boot=on|off parameter
46101d5973 block: Open backing image in force share mode for size probe
08eee649ae nvme: Add tracing
bc496836c8 block: Document that x-blockdev-change breaks quorum children list
8461abcc4b qcow2: get rid of qcow2_backing_read1 routine
3365d799b0 block: Don't acquire AioContext in hmp_qemu_io()
461f927b6b block: Unify order in drain functions
8305979755 block: Don't wait for requests in bdrv_drain*_end()
45e1429375 block: bdrv_drain_recurse(): Remove unused begin parameter
c3dc7191a6 test-bdrv-drain: Test BlockDriver callbacks for drain
220f56b835 block: Call .drain_begin only once in bdrv_drain_all_begin()
4ebba427bf block: Make bdrv_drain_invoke() recursive
d0200aff1b iotests: fix 197 for vpc
436ed0dac0 block: Formats don't need CONSISTENT_READ with NO_IO

=== OUTPUT BEGIN ===
Checking PATCH 1/35: block: Formats don't need CONSISTENT_READ with NO_IO...
Checking PATCH 2/35: iotests: fix 197 for vpc...
Checking PATCH 3/35: block: Make bdrv_drain_invoke() recursive...
Checking PATCH 4/35: block: Call .drain_begin only once in 
bdrv_drain_all_begin()...
Checking PATCH 5/35: test-bdrv-drain: Test BlockDriver callbacks for drain...
Checking PATCH 6/35: block: bdrv_drain_recurse(): Remove unused begin 
parameter...
Checking PATCH 7/35: block: Don't wait for requests in bdrv_drain*_end()...
Checking PATCH 8/35: block: Unify order in drain functions...
Checking PATCH 9/35: block: Don't acquire AioContext in hmp_qemu_io()...
Checking PATCH 10/35: qcow2: get rid of qcow2_backing_read1 routine...
Checking PATCH 11/35: block: Document that x-blockdev-change breaks quorum 
children list...
Checking PATCH 12/35: nvme: Add tracing...
Checking PATCH 13/35: block: Open backing image in force share mode for size 
probe...
Checking PATCH 14/35: block: Remove the obsolete -drive boot=on|off parameter...
Checking PATCH 15/35: block: Remove the deprecated -hdachs option...
Checking PATCH 16/35: block: Mention -drive cyls/heads/secs/trans/serial/addr 
in deprecation chapter...
Checking PATCH 17/35: block: Remove unused bdrv_requests_pending...
Checking PATCH 18/35: block: Assert drain_all is only called from main 
AioContext...
Checking PATCH 19/35: block: Make bdrv_drain() driver callbacks non-recursive...
Checking PATCH 20/35: test-bdrv-drain: Test callback for bdrv_drain...
ERROR: trailing statements should be on next line
#43: FILE: tests/test-bdrv-drain.c:92:
+    case BDRV_DRAIN_ALL:        bdrv_drain_all_begin(); break;

ERROR: trailing statements should be on next line
#44: FILE: tests/test-bdrv-drain.c:93:
+    case BDRV_DRAIN:            bdrv_drained_begin(bs); break;

ERROR: trailing statements should be on next line
#45: FILE: tests/test-bdrv-drain.c:94:
+    default:                    g_assert_not_reached();

ERROR: trailing statements should be on next line
#52: FILE: tests/test-bdrv-drain.c:101:
+    case BDRV_DRAIN_ALL:        bdrv_drain_all_end(); break;

ERROR: trailing statements should be on next line
#53: FILE: tests/test-bdrv-drain.c:102:
+    case BDRV_DRAIN:            bdrv_drained_end(bs); break;

ERROR: trailing statements should be on next line
#54: FILE: tests/test-bdrv-drain.c:103:
+    default:                    g_assert_not_reached();

total: 6 errors, 0 warnings, 113 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 21/35: test-bdrv-drain: Test bs->quiesce_counter...
ERROR: do not use C99 // comments
#54: FILE: tests/test-bdrv-drain.c:214:
+    // XXX drain_all doesn't quiesce

ERROR: do not use C99 // comments
#55: FILE: tests/test-bdrv-drain.c:215:
+    //test_quiesce_common(BDRV_DRAIN_ALL, true);

total: 2 errors, 0 warnings, 56 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 22/35: blockjob: Pause job on draining any job BDS...
Checking PATCH 23/35: test-bdrv-drain: Test drain vs. block jobs...
ERROR: initializer for struct BlockJobDriver should normally be const
#55: FILE: tests/test-bdrv-drain.c:252:
+BlockJobDriver test_job_driver = {

total: 1 errors, 0 warnings, 138 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 24/35: block: Don't block_job_pause_all() in bdrv_drain_all()...
Checking PATCH 25/35: block: Nested drain_end must still call callbacks...
Checking PATCH 26/35: test-bdrv-drain: Test nested drain sections...
Checking PATCH 27/35: block: Don't notify parents in drain call chain...
Checking PATCH 28/35: block: Add bdrv_subtree_drained_begin/end()...
Checking PATCH 29/35: test-bdrv-drain: Tests for bdrv_subtree_drain...
ERROR: trailing statements should be on next line
#27: FILE: tests/test-bdrv-drain.c:97:
+    case BDRV_SUBTREE_DRAIN:    bdrv_subtree_drained_begin(bs); break;

ERROR: trailing statements should be on next line
#35: FILE: tests/test-bdrv-drain.c:107:
+    case BDRV_SUBTREE_DRAIN:    bdrv_subtree_drained_end(bs); break;

total: 2 errors, 0 warnings, 83 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 30/35: test-bdrv-drain: Test behaviour in coroutine context...
ERROR: do not use C99 // comments
#90: FILE: tests/test-bdrv-drain.c:473:
+    // XXX bdrv_drain_all() doesn't work in coroutine context

ERROR: do not use C99 // comments
#101: FILE: tests/test-bdrv-drain.c:484:
+    // XXX bdrv_drain_all() doesn't work in coroutine context

total: 2 errors, 0 warnings, 88 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 31/35: test-bdrv-drain: Recursive draining with multiple 
parents...
Checking PATCH 32/35: block: Allow graph changes in subtree drained section...
Checking PATCH 33/35: test-bdrv-drain: Test graph changes in drained section...
Checking PATCH 34/35: commit: Simplify reopen of base...
Checking PATCH 35/35: block: Keep nodes drained between reopen_queue/multiple...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden