[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove legacy -no-kvm-pit option
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] Remove legacy -no-kvm-pit option |
Date: |
Tue, 19 Dec 2017 13:49:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 19.12.2017 11:56, Paolo Bonzini wrote:
> On 18/12/2017 18:44, Thomas Huth wrote:
>> It's only printing a warning since QEMU v1.3.0, so nobody should use
>> this anymore today. Let's get rid of this now.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> qemu-doc.texi | 5 -----
>> qemu-options.hx | 3 ---
>> vl.c | 4 ----
>> 3 files changed, 12 deletions(-)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 14d818d..d9861b3 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -2396,11 +2396,6 @@ synonym for setting ``-global
>> kvm-pit.lost_tick_policy=discard''.
>> The ``-no-kvm-irqchip'' argument is now a synonym for
>> setting ``-machine kernel_irqchip=off''.
>>
>> address@hidden -no-kvm-pit (since 1.3.0)
>> -
>> -The ``-no-kvm-pit'' argument is ignored. It is no longer
>> -possible to disable the KVM PIT directly.
>> -
>> @subsection -no-kvm (since 1.3.0)
>>
>> The ``-no-kvm'' argument is now a synonym for setting
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index fe0c292..aa0e849 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -4139,9 +4139,6 @@ HXCOMM Deprecated by kvm-pit driver properties
>> DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
>> "", QEMU_ARCH_I386)
>>
>> -HXCOMM Deprecated (ignored)
>> -DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>> -
>> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
>> DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>>
>> diff --git a/vl.c b/vl.c
>> index fc8bd93..2644400 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3818,10 +3818,6 @@ int main(int argc, char **argv, char **envp)
>> olist = qemu_find_opts("machine");
>> qemu_opts_parse_noisily(olist, "accel=tcg", false);
>> break;
>> - case QEMU_OPTION_no_kvm_pit: {
>> - warn_report("ignoring deprecated option");
>> - break;
>> - }
>> case QEMU_OPTION_no_kvm_pit_reinjection: {
>> static GlobalProperty kvm_pit_lost_tick_policy = {
>> .driver = "kvm-pit",
>>
>
> Queued, thanks. Please create the 2.12 changelog page and add it to the
> incompatible changes section.
Ok, I'll do that as soon as this patch hits the master branch.
Thomas