[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint |
Date: |
Mon, 18 Dec 2017 14:54:46 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/11/2017 04:57 AM, Alex Bennée wrote:
> + }
> + if (p.exp < DECOMPOSED_BINARY_POINT) {
> + return p.frac >> (DECOMPOSED_BINARY_POINT - p.exp);
> + } else if (p.exp < 64) {
> + return p.frac << (p.exp - DECOMPOSED_BINARY_POINT);
> + } else {
> + return UINT64_MAX;
> + }
> + default:
> + g_assert_not_reached();
> + }
> +}
> +
> +static uint16_t uint16_pack_decomposed(decomposed_parts p, float_status *s)
> +{
> + uint64_t r = uint64_pack_decomposed(p, s);
> + return r > UINT16_MAX ? UINT16_MAX : r;
> +}
> +
> +static uint32_t uint32_pack_decomposed(decomposed_parts p, float_status *s)
> +{
> + uint64_t r = uint64_pack_decomposed(p, s);
> + return r > UINT32_MAX ? UINT32_MAX : r;
> +}
Missing float_flag_invalid for unsigned overflows.
r~
- Re: [Qemu-devel] [PATCH v1 14/19] fpu/softfloat: re-factor round_to_int, (continued)
- [Qemu-devel] [PATCH v1 19/19] fpu/softfloat: re-factor compare, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 17/19] fpu/softfloat: re-factor scalbn, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 10/19] fpu/softfloat: re-factor add/sub, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 13/19] fpu/softfloat: re-factor muladd, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint, Alex Bennée, 2017/12/11
- Re: [Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint,
Richard Henderson <=
- [Qemu-devel] [PATCH v1 11/19] fpu/softfloat: re-factor mul, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 18/19] fpu/softfloat: re-factor minmax, Alex Bennée, 2017/12/11
- [Qemu-devel] [PATCH v1 12/19] fpu/softfloat: re-factor div, Alex Bennée, 2017/12/11
- Re: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions, no-reply, 2017/12/14