[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak |
Date: |
Fri, 15 Dec 2017 15:08:50 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/15/2017 12:06 PM, Marc-André Lureau wrote:
> Direct leak of 12 byte(s) in 2 object(s) allocated from:
> #0 0x7f50d403c850 in malloc (/lib64/libasan.so.4+0xde850)
> #1 0x7f50d1ddf98f in vasprintf (/lib64/libc.so.6+0x8098f)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/migration-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index be598d3257..799e24ebc6 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -358,13 +358,14 @@ static void migrate_check_parameter(QTestState *who,
> const char *parameter,
> const char *value)
> {
> QDict *rsp, *rsp_return;
> - const char *result;
> + char *result;
>
> rsp = wait_command(who, "{ 'execute': 'query-migrate-parameters' }");
> rsp_return = qdict_get_qdict(rsp, "return");
> result = g_strdup_printf("%" PRId64,
> qdict_get_try_int(rsp_return, parameter, -1));
> g_assert_cmpstr(result, ==, value);
> + g_free(result);
> QDECREF(rsp);
> }
>
>
- Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable, (continued)
- [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 05/13] tests: fix check-qobject leak:, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 09/13] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 07/13] readline: add a free function, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak, Marc-André Lureau, 2017/12/15
- Re: [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 10/13] qemu-config: fix leak in query-command-line-options, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 13/13] tests: fix coroutine leak in /basic/entered, Marc-André Lureau, 2017/12/15