[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes |
Date: |
Thu, 14 Dec 2017 19:49:21 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Michael S. Tsirkin (address@hidden) wrote:
> On Fri, Dec 15, 2017 at 12:36:30AM +0800, Jay Zhou wrote:
> > Jay Zhou (2):
> > vhost: add used memslot number for vhost-user
> > vhost: double check memslot number
> >
> > hw/virtio/vhost-user.c | 31 +++++++++++++++++++++++++
> > hw/virtio/vhost.c | 49
> > ++++++++++++++++++++++++++++++++++-----
> > include/hw/virtio/vhost-backend.h | 4 ++++
> > 3 files changed, 78 insertions(+), 6 deletions(-)
>
> Cc two developers working on these files right now.
I have to admit to not understanding the 'used_memslots' variable.
* It's a global in vhost.c
* but set by vhost_set_memory that's called from the listener associated
with each individual vhost
* While they're probably always the same, the merging code calls
the vhost_backend_can_merge method for each device, so the number
of regions can be different.
Dave
> > --
> > 1.8.3.1
> >
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK