Re: [Qemu-devel] [PATCH 0/4] virtio-vfc implementation

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] virtio-vfc implementation
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d8dd333123 scsi: support REPORT_LUNS for LUNs != 0
a0b56536ca virtio-scsi: Implement 'native LUN' feature
33b2896368 virtio-scsi: implement target rescan
05ddb085cd scsi: use 64-bit LUN

=== OUTPUT BEGIN ===
Checking PATCH 1/4: scsi: use 64-bit LUN...
WARNING: line over 80 characters
#110: FILE: hw/scsi/megasas.c:1339:
+        uint16_t sdev_id = ((sdev->id & 0xFF) << 8) | 
scsi_lun_to_int(sdev->lun);

WARNING: line over 80 characters
#227: FILE: hw/scsi/scsi-bus.c:71:
+static SCSIRequest *scsi_device_alloc_req(SCSIDevice *s, uint32_t tag, 
uint64_t lun,

WARNING: line over 80 characters
#301: FILE: hw/scsi/scsi-bus.c:225:
+        if (scsi_device_count(bus, dev->channel, dev->id) >= 
bus->info->max_lun) {

WARNING: line over 80 characters
#504: FILE: hw/scsi/scsi-bus.c:1626:
+                               qdev_fw_name(dev), d->id, 
scsi_lun_to_int(d->lun));

WARNING: line over 80 characters
#597: FILE: hw/scsi/spapr_vscsi.c:139:
+static SCSIDevice *vscsi_device_find(SCSIBus *bus, uint64_t srp_lun, uint64_t 
*lun)

ERROR: spaces required around that '+' (ctx:VxV)
#638: FILE: hw/scsi/spapr_vscsi.c:755:
+        resp_data[i+1] |= scsi_lun_to_int(dev->lun);
                    ^

WARNING: line over 80 characters
#749: FILE: hw/scsi/vmw_pvscsi.c:833:
+    trace_pvscsi_on_cmd_reset_dev(cmd->target, scsi_lun_to_int(target_lun), 
sdev);

ERROR: spaces required around that '+' (ctx:VxV)
#763: FILE: hw/usb/dev-storage.c:375:
+                                        scsi_lun_from_int(maxlun+1));
                                                                 ^

ERROR: spaces required around that '+' (ctx:VxV)
#768: FILE: hw/usb/dev-storage.c:379:
+            if (scsi_lun_to_int(scsi_dev->lun) != maxlun+1) {
                                                         ^

WARNING: line over 80 characters
#964: FILE: include/hw/scsi/scsi.h:228:
+SCSIDevice *scsi_device_find(SCSIBus *bus, int channel, int target, uint64_t 
lun);

total: 3 errors, 7 warnings, 829 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/4: virtio-scsi: implement target rescan...
ERROR: do not use C99 // comments
#52: FILE: hw/scsi/scsi-disk.c:671:
+                outbuf[buflen++] = s->qdev.protocol << 8 | 0x1; // Binary

ERROR: do not use C99 // comments
#61: FILE: hw/scsi/scsi-disk.c:680:
+                outbuf[buflen++] = s->qdev.protocol << 8 | 0x1; // Binary

total: 2 errors, 0 warnings, 242 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/4: virtio-scsi: Implement 'native LUN' feature...
Checking PATCH 4/4: scsi: support REPORT_LUNS for LUNs != 0...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden