[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize met
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded |
|
Date: |
Fri, 8 Dec 2017 23:08:33 -0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Dec 07, 2017 at 06:14:48PM +0000, Peter Maydell wrote:
> We were passing a NULL error pointer to the object_property_set_bool()
> call that realizes the CPU object. This meant that we wouldn't detect
> failure, and would plough blindly on to crash later trying to use a
> NULL CPU object pointer. Detect errors and fail instead.
>
> In particular, this will be necessary to detect the user error
> of using "-cpu host" without "-enable-kvm" once we make the host
> CPU type be registered unconditionally rather than only in
> kvm_arch_init().
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
- [Qemu-devel] [PATCH 0/6] arm: support -cpu max (and gic-version=max), Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 6/6] hw/arm/virt: Support -machine gic-version=max, Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 5/6] hw/arm/virt: Add "max" to the list of CPU types "virt" supports, Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 3/6] target/arm: Move definition of 'host' cpu type into cpu.c, Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 2/6] target/arm: Query host CPU features on-demand at instance init, Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support, Peter Maydell, 2017/12/07
- [Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded, Peter Maydell, 2017/12/07
- Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded,
Eduardo Habkost <=
- Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max), Peter Maydell, 2017/12/07