[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress thre
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests |
Date: |
Fri, 8 Dec 2017 11:46:01 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> Yeap, it is still not working. trying to learn how to debug threads
> for guests running from the testt hardness.
>
> For some reason, compression is not working at the moment, test is
> disabled until I found why.
How does it fail?
Dave
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> tests/migration-test.c | 51
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 41dee78a9a..eab3b146a4 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -739,6 +739,54 @@ static void test_xbzrle_unix(void)
> g_free(uri);
> }
>
> +static void test_compress(const char *uri)
> +{
> + QTestState *from, *to;
> +
> + test_migrate_start(&from, &to, uri);
> +
> + /* We want to pick a speed slow enough that the test completes
> + * quickly, but that it doesn't complete precopy even on a slow
> + * machine, so also set the downtime.
> + */
> + /* 100 ms */
> + migrate_set_parameter(from, "downtime-limit", "1");
> + /* 1MB/s slow*/
> + migrate_set_parameter(from, "max-bandwidth", "100000000");
> +
> + migrate_set_parameter(from, "compress-threads", "4");
> + migrate_set_parameter(to, "decompress-threads", "3");
> +
> + migrate_set_capability(from, "compress", "true");
> + migrate_set_capability(to, "compress", "true");
> + /* Wait for the first serial output from the source */
> + wait_for_serial("src_serial");
> +
> + migrate(from, uri);
> +
> + wait_for_migration_pass(from);
> +
> + /* 300ms it should converge */
> + migrate_set_parameter(from, "downtime-limit", "300");
> +
> + if (!got_stop) {
> + qtest_qmp_eventwait(from, "STOP");
> + }
> + qtest_qmp_eventwait(to, "RESUME");
> +
> + wait_for_serial("dest_serial");
> + wait_for_migration_complete(from);
> +
> + test_migrate_end(from, to);
> +}
> +
> +static void test_compress_unix(void)
> +{
> + char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
> +
> + test_compress(uri);
> + g_free(uri);
> +}
>
> int main(int argc, char **argv)
> {
> @@ -763,6 +811,9 @@ int main(int argc, char **argv)
> qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
> qtest_add_func("/migration/postcopy/unix", test_postcopy);
> qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);
> + if (0) {
> + qtest_add_func("/migration/compress/unix", test_compress_unix);
> + }
>
> ret = g_test_run();
>
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v3 4/6] tests: Add basic migration precopy tcp test, (continued)
- [Qemu-devel] [PATCH v3 2/6] tests: migration test deprecated commands, Juan Quintela, 2017/12/01
- [Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test, Juan Quintela, 2017/12/01
- [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests, Juan Quintela, 2017/12/01
- Re: [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v3 1/6] migration: free result string, Juan Quintela, 2017/12/01
- [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test, Juan Quintela, 2017/12/01
- Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration, Eric Blake, 2017/12/01