[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx()
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32() |
Date: |
Tue, 5 Dec 2017 16:16:48 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
Am 05.12.2017 um 16:13 schrieb Stefan Weil:
> Am 05.12.2017 um 09:17 schrieb Mark Cave-Ayland:
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> ---
>> hw/net/eepro100.c | 19 +------------------
>> 1 file changed, 1 insertion(+), 18 deletions(-)
>>
>> diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
>> index 1c0def555b..4fe94b7471 100644
>> --- a/hw/net/eepro100.c
>> +++ b/hw/net/eepro100.c
>> @@ -327,26 +327,9 @@ static const uint16_t eepro100_mdi_mask[] = {
>>
>> static E100PCIDeviceInfo *eepro100_get_class(EEPRO100State *s);
>>
>> -/* From FreeBSD (locally modified). */
>> static unsigned e100_compute_mcast_idx(const uint8_t *ep)
>> {
>> - uint32_t crc;
>> - int carry, i, j;
>> - uint8_t b;
>> -
>> - crc = 0xffffffff;
>> - for (i = 0; i < 6; i++) {
>> - b = *ep++;
>> - for (j = 0; j < 8; j++) {
>> - carry = ((crc & 0x80000000L) ? 1 : 0) ^ (b & 0x01);
>> - crc <<= 1;
>> - b >>= 1;
>> - if (carry) {
>> - crc = ((crc ^ POLYNOMIAL) | carry);
>> - }
>> - }
>> - }
>> - return (crc & BITS(7, 2)) >> 2;
>> + return (net_crc32(ep, 6) & BITS(7, 2)) >> 2;
>> }
>>
>> /* Read a 16 bit control/status (CSR) register. */
>
>
> What about eliminating the intermediate function e100_compute_mcast_idx (and
> function lnc_mchash, too)?
> You did that for lnc_mchash, and I think that is cleaner and saves some lines
> of code.
This should be "You did that for sunhme_crc32_le" ...
Stefan
- [Qemu-devel] [PATCHv2 1/5] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, (continued)
- [Qemu-devel] [PATCHv2 1/5] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, Mark Cave-Ayland, 2017/12/05
- [Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function, Mark Cave-Ayland, 2017/12/05
- [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32(), Mark Cave-Ayland, 2017/12/05
- [Qemu-devel] [PATCHv2 5/5] sunhme: switch sunhme_receive() over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/05
- [Qemu-devel] [PATCHv2 3/5] pcnet: switch lnc_mchash() over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/05