Re: [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

[Michael S. Tsirkin]

On Fri, Dec 01, 2017 at 06:05:25PM +0000, Peter Maydell wrote:
> On 1 December 2017 at 17:08, Michael S. Tsirkin <address@hidden> wrote:
> > The following changes since commit c11d61271b9e6e7a1f0479ef1ca8fb55fa457a62:
> >
> >   Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 75ba2ddb188fa07c3442446766782036e3085cba:
> >
> >   pc: fix crash on attempted cpu unplug (2017-12-01 19:05:58 +0200)
> >
> > ----------------------------------------------------------------
> > pc, pci, virtio: fixes for rc3
> >
> > A bunch of fixes all over the place.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> >
> > ----------------------------------------------------------------
> 
> You can't send fixes for rc3 2 days after rc3 has been tagged :-)

Bad wording. I meant they are for bugs present in rc3.

> > Chao Gao (1):
> >       i386/msi: Correct mask of destination ID in MSI address
> >
> > Greg Kurz (1):
> >       vhost: fix error check in vhost_verify_ring_mappings()
> >
> > Igor Mammedov (1):
> >       pc: fix crash on attempted cpu unplug
> >
> > Marc-André Lureau (1):
> >       dump-guest-memory.py: fix No symbol "vmcoreinfo_find"
> >
> > Maxime Coquelin (2):
> >       virtio: Add queue interface to restore avail index from vring used 
> > index
> >       vhost: restore avail index from vring used index on disconnection
> >
> > Prasad J Pandit (1):
> >       virtio: check VirtQueue Vring object is set
> 
> Are any of these so important that we would absolutely refuse
> to release without the fixes (ie they justify rolling an rc4
> that we would otherwise not have needed) ?
> 
> thanks
> -- PMM

The msi one is less important it just happened to be queued a while ago
and I didn't want to rebase all testing. Others are crashers but they
don't affect everyone. So I wouldn't be sure, but there's also a
security fix in there, so yes, I suspect we are better off with rc4, and
if we do I think including others is justified (except maybe the msi
one, if you feel strongly I'll rebase and drop it).

-- 
MST