Re: [Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code)

[Max Reitz]

On 2017-11-16 18:38, Cleber Rosa wrote:
> The $seq.full file, in theory, should contain the full output of a
> test error.  In practice, it's only used on a single test, and the
> boiler plate code to clean it up plagues all other tests.
> 
> Let's remove the concept altogether, and record the failure in the
> output itself for the one test using this function.
> 
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
>  tests/qemu-iotests/001 | 1 -
>  tests/qemu-iotests/002 | 1 -
>  tests/qemu-iotests/003 | 1 -
>  tests/qemu-iotests/004 | 1 -
>  tests/qemu-iotests/005 | 1 -
>  tests/qemu-iotests/007 | 1 -
>  tests/qemu-iotests/008 | 1 -
>  tests/qemu-iotests/009 | 1 -
>  tests/qemu-iotests/010 | 1 -
>  tests/qemu-iotests/011 | 1 -
>  tests/qemu-iotests/012 | 1 -
>  tests/qemu-iotests/013 | 1 -
>  tests/qemu-iotests/014 | 1 -
>  tests/qemu-iotests/015 | 1 -
>  tests/qemu-iotests/017 | 1 -
>  tests/qemu-iotests/018 | 1 -
>  tests/qemu-iotests/019 | 1 -
>  tests/qemu-iotests/020 | 1 -
>  tests/qemu-iotests/021 | 1 -
>  tests/qemu-iotests/022 | 1 -
>  tests/qemu-iotests/023 | 1 -
>  tests/qemu-iotests/024 | 1 -
>  tests/qemu-iotests/025 | 1 -
>  tests/qemu-iotests/026 | 1 -
>  tests/qemu-iotests/027 | 1 -
>  tests/qemu-iotests/028 | 1 -
>  tests/qemu-iotests/029 | 1 -
>  tests/qemu-iotests/031 | 1 -
>  tests/qemu-iotests/032 | 1 -
>  tests/qemu-iotests/033 | 1 -
>  tests/qemu-iotests/034 | 1 -
>  tests/qemu-iotests/035 | 1 -
>  tests/qemu-iotests/036 | 1 -
>  tests/qemu-iotests/037 | 1 -
>  tests/qemu-iotests/038 | 1 -
>  tests/qemu-iotests/039 | 1 -
>  tests/qemu-iotests/042 | 1 -
>  tests/qemu-iotests/043 | 1 -
>  tests/qemu-iotests/046 | 1 -
>  tests/qemu-iotests/047 | 1 -
>  tests/qemu-iotests/049 | 1 -
>  tests/qemu-iotests/050 | 1 -
>  tests/qemu-iotests/051 | 1 -
>  tests/qemu-iotests/052 | 1 -
>  tests/qemu-iotests/053 | 1 -
>  tests/qemu-iotests/054 | 1 -
>  tests/qemu-iotests/058 | 1 -
>  tests/qemu-iotests/059 | 1 -
>  tests/qemu-iotests/060 | 1 -
>  tests/qemu-iotests/061 | 1 -
>  tests/qemu-iotests/062 | 1 -
>  tests/qemu-iotests/063 | 1 -
>  tests/qemu-iotests/064 | 1 -
>  tests/qemu-iotests/066 | 1 -
>  tests/qemu-iotests/067 | 1 -
>  tests/qemu-iotests/068 | 1 -
>  tests/qemu-iotests/069 | 1 -
>  tests/qemu-iotests/070 | 1 -
>  tests/qemu-iotests/071 | 1 -
>  tests/qemu-iotests/072 | 1 -
>  tests/qemu-iotests/073 | 1 -
>  tests/qemu-iotests/075 | 1 -
>  tests/qemu-iotests/076 | 1 -
>  tests/qemu-iotests/077 | 1 -
>  tests/qemu-iotests/078 | 1 -
>  tests/qemu-iotests/079 | 1 -
>  tests/qemu-iotests/080 | 1 -
>  tests/qemu-iotests/081 | 1 -
>  tests/qemu-iotests/082 | 1 -
>  tests/qemu-iotests/083 | 1 -
>  tests/qemu-iotests/084 | 1 -
>  tests/qemu-iotests/085 | 1 -
>  tests/qemu-iotests/086 | 1 -
>  tests/qemu-iotests/087 | 1 -
>  tests/qemu-iotests/088 | 1 -
>  tests/qemu-iotests/089 | 1 -
>  tests/qemu-iotests/090 | 1 -
>  tests/qemu-iotests/091 | 1 -
>  tests/qemu-iotests/092 | 1 -
>  tests/qemu-iotests/094 | 1 -
>  tests/qemu-iotests/095 | 1 -
>  tests/qemu-iotests/097 | 1 -
>  tests/qemu-iotests/098 | 1 -
>  tests/qemu-iotests/099 | 1 -
>  tests/qemu-iotests/101 | 1 -
>  tests/qemu-iotests/102 | 1 -
>  tests/qemu-iotests/103 | 1 -
>  tests/qemu-iotests/104 | 1 -
>  tests/qemu-iotests/105 | 1 -
>  tests/qemu-iotests/106 | 1 -
>  tests/qemu-iotests/107 | 1 -
>  tests/qemu-iotests/108 | 1 -
>  tests/qemu-iotests/109 | 1 -
>  tests/qemu-iotests/110 | 1 -
>  tests/qemu-iotests/111 | 1 -
>  tests/qemu-iotests/112 | 1 -
>  tests/qemu-iotests/113 | 1 -
>  tests/qemu-iotests/114 | 1 -
>  tests/qemu-iotests/115 | 1 -
>  tests/qemu-iotests/116 | 1 -
>  tests/qemu-iotests/117 | 1 -
>  tests/qemu-iotests/119 | 1 -
>  tests/qemu-iotests/120 | 1 -
>  tests/qemu-iotests/121 | 1 -
>  tests/qemu-iotests/122 | 1 -
>  tests/qemu-iotests/123 | 1 -
>  tests/qemu-iotests/125 | 1 -
>  tests/qemu-iotests/126 | 1 -
>  tests/qemu-iotests/127 | 1 -
>  tests/qemu-iotests/128 | 1 -
>  tests/qemu-iotests/130 | 1 -
>  tests/qemu-iotests/131 | 1 -
>  tests/qemu-iotests/133 | 1 -
>  tests/qemu-iotests/134 | 1 -
>  tests/qemu-iotests/135 | 1 -
>  tests/qemu-iotests/137 | 1 -
>  tests/qemu-iotests/138 | 1 -
>  tests/qemu-iotests/140 | 1 -
>  tests/qemu-iotests/141 | 1 -
>  tests/qemu-iotests/142 | 1 -
>  tests/qemu-iotests/143 | 1 -
>  tests/qemu-iotests/144 | 1 -
>  tests/qemu-iotests/145 | 1 -
>  tests/qemu-iotests/146 | 1 -
>  tests/qemu-iotests/150 | 1 -
>  tests/qemu-iotests/153 | 1 -
>  tests/qemu-iotests/154 | 1 -
>  tests/qemu-iotests/156 | 1 -
>  tests/qemu-iotests/157 | 1 -
>  tests/qemu-iotests/158 | 1 -
>  tests/qemu-iotests/162 | 1 -
>  tests/qemu-iotests/171 | 1 -
>  tests/qemu-iotests/172 | 1 -
>  tests/qemu-iotests/173 | 1 -
>  tests/qemu-iotests/174 | 9 +++++++--
>  tests/qemu-iotests/175 | 1 -
>  tests/qemu-iotests/176 | 1 -
>  tests/qemu-iotests/178 | 1 -
>  tests/qemu-iotests/181 | 1 -
>  tests/qemu-iotests/182 | 1 -
>  tests/qemu-iotests/183 | 1 -
>  tests/qemu-iotests/184 | 1 -
>  tests/qemu-iotests/185 | 1 -
>  tests/qemu-iotests/186 | 1 -
>  tests/qemu-iotests/187 | 1 -
>  tests/qemu-iotests/188 | 1 -
>  tests/qemu-iotests/189 | 1 -
>  tests/qemu-iotests/190 | 1 -
>  tests/qemu-iotests/191 | 1 -
>  tests/qemu-iotests/192 | 1 -
>  tests/qemu-iotests/195 | 1 -
>  151 files changed, 7 insertions(+), 152 deletions(-)

Looks good, but I guess it would make sense to drop the _fail function
from common.rc then, too.

Another thought: Seeing the status=1...  I think besides the _fail
thing, 174 is also the only test that makes use of $status.  How about a
patch that removes that variable and simply performs "exit 1" in the
trap line?  I think all tests just do an immediate "exit 1" on error anyway.

Max

signature.asc
Description: OpenPGP digital signature