Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo

[Alex Williamson]

On Thu, 30 Nov 2017 12:56:09 +1100
Alexey Kardashevskiy <address@hidden> wrote:

> On 30/11/17 02:36, Alex Williamson wrote:
> > On Wed, 22 Nov 2017 18:39:47 +1100
> > Alexey Kardashevskiy <address@hidden> wrote:
> > 
> > Missing reference to commit that made these fields unused.  A Fixes tag
> > to that commit also seems appropriate.  An empty commit log is pretty
> > much never justified.  
> 
> Ah. Right, sorry. I could not find when it was used, looks like never.

Nope, db0da029a185 vfio: Generalize region support

> > This also looks like 2.12 material.  Thanks,  
> 
> Indeed 2.12.
> 
> 
> > 
> > Alex
> >   
> >> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> >> ---
> >>  hw/vfio/pci.h | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> >> index c5e168e..06dcf99 100644
> >> --- a/hw/vfio/pci.h
> >> +++ b/hw/vfio/pci.h
> >> @@ -93,8 +93,6 @@ typedef struct VFIOMSIXInfo {
> >>      uint16_t entries;
> >>      uint32_t table_offset;
> >>      uint32_t pba_offset;
> >> -    MemoryRegion mmap_mem;
> >> -    void *mmap;
> >>      unsigned long *pending;
> >>  } VFIOMSIXInfo;
> >>    
> >   
> 
>