[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref() |
Date: |
Tue, 28 Nov 2017 16:59:51 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 28.11.2017 um 16:53 hat Alberto Garcia geschrieben:
> On Tue 28 Nov 2017 03:53:27 PM CET, Alberto Garcia wrote:
> > When destroying a block job in block_job_unref() we should remove it
> > from the job list before calling block_job_remove_all_bdrv().
> >
> > This is because removing the BDSs can trigger an aio_poll() and wake
> > up other jobs that might attempt to use the block job list. If that
> > happens the job we're currently destroying should not be in that list
> > anymore.
> > ---
> > blockjob.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I forgot this
>
> Signed-off-by: Alberto Garcia <address@hidden>
Thanks, applied to the block branch.
Kevin