[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge |
|
Date: |
Tue, 28 Nov 2017 15:02:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Looks good to me and is similar to the other devices (e.g. the IPL device)
Reviewed-by: Christian Borntraeger <address@hidden>
On 11/28/2017 02:46 PM, Cornelia Huck wrote:
> Logically, the css bridge should be attached to the machine.
>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> hw/s390x/css-bridge.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> index c4a9735d71..84d33eafc2 100644
> --- a/hw/s390x/css-bridge.c
> +++ b/hw/s390x/css-bridge.c
> @@ -99,6 +99,8 @@ VirtualCssBus *virtual_css_bus_init(void)
>
> /* Create bridge device */
> dev = qdev_create(NULL, TYPE_VIRTUAL_CSS_BRIDGE);
> + object_property_add_child(qdev_get_machine(), TYPE_VIRTUAL_CSS_BRIDGE,
> + OBJECT(dev), NULL);
> qdev_init_nofail(dev);
>
> /* Create bus on bridge device */
>