Re: [Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files

[Ladi Prosek]

On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov
<address@hidden> wrote:
> Signed-off-by: Mihail Abakumov <address@hidden>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Dmitriy Koltunov <address@hidden>
> ---
>  Makefile.target                 |    7 +++++++
>  include/exec/windbgstub-utils.h |   18 ++++++++++++++++++
>  include/exec/windbgstub.h       |   17 +++++++++++++++++
>  stubs/Makefile.objs             |    1 +
>  stubs/windbgstub.c              |   18 ++++++++++++++++++
>  target/i386/Makefile.objs       |    2 +-
>  target/i386/windbgstub.c        |   12 ++++++++++++
>  windbgstub-utils.c              |   12 ++++++++++++
>  windbgstub.c                    |   19 +++++++++++++++++++
>  9 files changed, 105 insertions(+), 1 deletion(-)
>  create mode 100755 include/exec/windbgstub-utils.h
>  create mode 100755 include/exec/windbgstub.h
>  create mode 100755 stubs/windbgstub.c
>  create mode 100755 target/i386/windbgstub.c
>  create mode 100755 windbgstub-utils.c
>  create mode 100755 windbgstub.c
>
> diff --git a/Makefile.target b/Makefile.target
> index 7f42c45db8..6df0836509 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -148,6 +148,13 @@ obj-y += dump.o
>  obj-y += migration/ram.o
>  LIBS := $(libs_softmmu) $(LIBS)
>
> +# WinDbg support
> +ifeq ($(TARGET_NAME), i386)
> +ifneq ($(TARGET_NAME), x86_64)

This is odd. Did you add the second by mistake? Thanks!