[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages to support virtio config space |
Date: |
Tue, 21 Nov 2017 01:16:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 20/11/2017 21:44, Michael S. Tsirkin wrote:
> Live migrations is supposed to be migrating guest writeable state too.
> If you mean migrating RO fields like size, then
> I don't think it's a good idea to reuse SET_CONFIG for that.
> SET_CONFIG should obey exactly the virtio semantics.
>
> And I agree, it should say that slave must treat it as a write,
> and get config as a read according to virtio semantics.
>
> If someone needs to pass configuration from qemu to
> slave, let's add specific messages with precisely defined semantics.
Fair enough, but I'd add nevertheless a 32-bit flags field to both
GET_CONFIG and SET_CONFIG, and document that the slave MUST check that
it is zero and otherwise fail.
Paolo
Re: [Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages to support virtio config space, Michael S. Tsirkin, 2017/11/22
[Qemu-devel] [PATCH v5 3/4] contrib/libvhost-user: enable virtio config space messages, Changpeng Liu, 2017/11/16
[Qemu-devel] [PATCH v5 2/4] vhost-user-blk: introduce a new vhost-user-blk host device, Changpeng Liu, 2017/11/16
[Qemu-devel] [PATCH v5 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application, Changpeng Liu, 2017/11/16