[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support |
Date: |
Fri, 17 Nov 2017 15:06:22 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Nov 17, 2017 at 02:59:54PM +0000, Daniel P. Berrange wrote:
> On Fri, Nov 17, 2017 at 03:49:06PM +0100, Gerd Hoffmann wrote:
> > On Fri, Nov 17, 2017 at 02:21:30PM +0000, Daniel P. Berrange wrote:
> > > On Fri, Nov 17, 2017 at 11:30:23AM +0100, Gerd Hoffmann wrote:
> > > > SDL2 doesn't support this any more, the SDL_NOFRAME window flag is gone.
> > > > Drop the code, print a notice when the option is still used.
> > > >
> > > > Signed-off-by: Gerd Hoffmann <address@hidden>
> > > > ---
> > > > include/ui/console.h | 5 ++---
> > > > ui/sdl.c | 8 +-------
> > > > ui/sdl2.c | 7 +------
> > > > vl.c | 15 ++++-----------
> > > > 4 files changed, 8 insertions(+), 27 deletions(-)
> > >
> > > This needs to go through the deprecation process before we can
> > > drop it. There's still time to get it into 2.11 deprecated list
> > > which would cut the time needed to wait for real deletion.
> >
> > I fail to see the point. SDL2 simply doesn't support it, so it never
> > worked with SDL2. We switched to SDL2 as default recently. So it seems
> > fair to me to just say so instead of silently ignoring the option ...
>
> We still support SDL don't we, which does support it, and which this
> option was targetted at ?
Perhaps we might even consider deprecating SDL1 as a whole, then the
deprecation of -no-frame is a natural side effect ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default, (continued)
[Qemu-devel] [PATCH 17/24] curses: hook up to display registry, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 18/24] egl-headless: hook up to display registry, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 23/24] curses: build as module, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 16/24] cocoa: hook up to display registry, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 24/24] build: opengl should not need X11, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 14/24] console: add qemu display registry, add gtk, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 20/24] console: add ui module loading support, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 05/24] gtk: add and use DisplayOptions + DisplayGTK, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 22/24] gtk: build as module, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 15/24] sdl: hook up to display registry, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 06/24] sdl: use DisplayOptions, Gerd Hoffmann, 2017/11/17
[Qemu-devel] [PATCH 10/24] cocoa: use DisplayOptions, Gerd Hoffmann, 2017/11/17