Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support

[Daniel P. Berrange]

On Fri, Nov 17, 2017 at 03:49:06PM +0100, Gerd Hoffmann wrote:
> On Fri, Nov 17, 2017 at 02:21:30PM +0000, Daniel P. Berrange wrote:
> > On Fri, Nov 17, 2017 at 11:30:23AM +0100, Gerd Hoffmann wrote:
> > > SDL2 doesn't support this any more, the SDL_NOFRAME window flag is gone.
> > > Drop the code, print a notice when the option is still used.
> > > 
> > > Signed-off-by: Gerd Hoffmann <address@hidden>
> > > ---
> > >  include/ui/console.h |  5 ++---
> > >  ui/sdl.c             |  8 +-------
> > >  ui/sdl2.c            |  7 +------
> > >  vl.c                 | 15 ++++-----------
> > >  4 files changed, 8 insertions(+), 27 deletions(-)
> > 
> > This needs to go through the deprecation process before we can
> > drop it. There's still time to get it into 2.11 deprecated list
> > which would cut the time needed to wait for real deletion.
> 
> I fail to see the point.  SDL2 simply doesn't support it, so it never
> worked with SDL2.  We switched to SDL2 as default recently.  So it seems
> fair to me to just say so instead of silently ignoring the option ...

We still support SDL don't we, which does support it, and which this
option was targetted at ?

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|