[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID in MSI address |
|
Date: |
Fri, 17 Nov 2017 15:24:21 +0200 |
On Fri, Nov 17, 2017 at 02:24:23PM +0800, Chao Gao wrote:
> According to SDM 10.11.1, only [19:12] bits of MSI address are
> Destination ID, change the mask to avoid ambiguity for VT-d spec
> has used the bit 4 to indicate a remappable interrupt request.
>
> Signed-off-by: Chao Gao <address@hidden>
> Signed-off-by: Lan Tianyu <address@hidden>
> Reviewed-by: Anthony PERARD <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Do you want me to merge this?
> ---
> include/hw/i386/apic-msidef.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
> index 8b4d4cc..420b411 100644
> --- a/include/hw/i386/apic-msidef.h
> +++ b/include/hw/i386/apic-msidef.h
> @@ -26,6 +26,6 @@
>
> #define MSI_ADDR_DEST_ID_SHIFT 12
> #define MSI_ADDR_DEST_IDX_SHIFT 4
> -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
> +#define MSI_ADDR_DEST_ID_MASK 0x000ff000
>
> #endif /* HW_APIC_MSIDEF_H */
> --
> 1.8.3.1