Re: [Qemu-devel] [PATCH for-2.11] tests/bios-tables-test: Fix endianess problems when passing data to iasl

[Daniel P. Berrange]

On Thu, Nov 16, 2017 at 09:55:46AM +0100, Thomas Huth wrote:
> The bios-tables-test was writing out files that we pass to iasl in
> with the wrong endianness in the header when running on a big endian
> host. So instead of storing mixed endian information in our structures,
> let's keep everything in little endian and byte-swap it only when we
> need a value in the code.
> 
> Reported-by: Daniel P. Berrange <address@hidden>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1724570
> Suggested-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  tests/acpi-utils.h       | 27 +++++----------------------
>  tests/bios-tables-test.c | 42 ++++++++++++++++++++++--------------------
>  2 files changed, 27 insertions(+), 42 deletions(-)

This fixes bios-tables-test, but has broken vmgenid-tgst

TEST: tests/vmgenid-test... (pid=8197)
  /i386/vmgenid/vmgenid/set-guid:                                      **
ERROR:/builddir/build/BUILD/qemu-2.10.0/tests/vmgenid-test.c:62:acpi_find_vgia: 
assertion failed (ACPI_ASSERT_CMP_str == "RSDT"): ("" == "RSDT")
FAIL
GTester: last random seed: R02S1ab59ff8ca3a4e0f7ff4b8bbddb007f1
(pid=8204)
  /i386/vmgenid/vmgenid/set-guid-auto:                                 **
ERROR:/builddir/build/BUILD/qemu-2.10.0/tests/vmgenid-test.c:62:acpi_find_vgia: 
assertion failed (ACPI_ASSERT_CMP_str == "RSDT"): ("" == "RSDT")
FAIL
GTester: last random seed: R02S1c3bcc9f459161566b19571adc5cb5d1
(pid=8216)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|