[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/10] test: fix detection of errors from iasl
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 04/10] test: fix detection of errors from iasl |
Date: |
Wed, 15 Nov 2017 20:18:13 +0200 |
From: "Daniel P. Berrange" <address@hidden>
The conditional looking for errors while loading asl files would ignore
errors from loading the expected data, if the actual data succeeded.
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
tests/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index ee441f1..be05e8b 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
exp_asl = normalize_asl(exp_sdt->asl);
/* TODO: check for warnings */
- g_assert(!err || exp_err);
+ g_assert(!err && !exp_err);
if (g_strcmp0(asl->str, exp_asl->str)) {
if (exp_err) {
--
MST
- [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 01/10] fix: unrealize virtio device if we fail to hotplug it, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 02/10] pci: Initialize pci_dev->name before use, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 03/10] tests: report errors when iasl exits with non-zero status, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 04/10] test: fix detection of errors from iasl,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 05/10] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 06/10] hw/pcie-pci-bridge: restrict to X86 and ARM, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 07/10] tests/acpi-test-data: update _CRS in DSDT, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 08/10] NUMA: Enable adding NUMA node implicitly, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 09/10] vmcoreinfo: put it in the 'misc' device category, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 10/10] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets, Michael S. Tsirkin, 2017/11/15
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Peter Maydell, 2017/11/16