|
From: | Dou Liyang |
Subject: | Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly |
Date: | Wed, 15 Nov 2017 09:29:22 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Igor, [...]
+ parse_numa_node(ms, &node, NULL);I get build break here: numa.c:451:13: error: too few arguments to function ‘parse_numa_node’ parse_numa_node(ms, &node, NULL);
In upstream tree, your commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier") removed a argument from parse_numa_node() recently. this definition of function becomes static void parse_numa_node(MachineState *ms, NumaNodeOptions *node, Error **errp) this patch is based on the upstream tree, parse_numa_node() should have three arguments. I am not sure why you got this building failure log, can you tell me which branch did you test? Thanks, dou
[Prev in Thread] | Current Thread | [Next in Thread] |