[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11? v7 6/6] tests: Add check-qobject for e
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11? v7 6/6] tests: Add check-qobject for equality tests |
Date: |
Tue, 14 Nov 2017 13:35:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/14/2017 12:01 PM, Max Reitz wrote:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> + * Note that qobject_is_equal() is not really an equivalence relation,
> + * so this function may not be used for all objects (reflexivity is
> + * not guaranteed, e.g. in the case of a QNum containing NaN).
> + *
> + * The @_ argument is required because a boolean may not be the last
> + * argument before a variadic argument list (C11 7.16.1.4 para. 4).
C99 7.15.1.4 (did C11 add a section? /me goes and looks... Oh, it did.)
Okay, so it's not a typo after all. Ignore my comment in the cover
letter, and
Reviewed-by: Eric Blake <address@hidden>
(And soon, I'll have to start quoting C17 instead of C99 or C11...)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.11? v7 0/6] block: Don't compare strings in bdrv_reopen_prepare(), Max Reitz, 2017/11/14
- [Qemu-devel] [PATCH for-2.11? v7 1/6] qapi/qnull: Add own header, Max Reitz, 2017/11/14
- [Qemu-devel] [PATCH for-2.11? v7 2/6] qapi/qlist: Add qlist_append_null() macro, Max Reitz, 2017/11/14
- [Qemu-devel] [PATCH for-2.11? v7 4/6] block: qobject_is_equal() in bdrv_reopen_prepare(), Max Reitz, 2017/11/14
- [Qemu-devel] [PATCH for-2.11? v7 5/6] iotests: Add test for non-string option reopening, Max Reitz, 2017/11/14
- [Qemu-devel] [PATCH for-2.11? v7 6/6] tests: Add check-qobject for equality tests, Max Reitz, 2017/11/14
- Re: [Qemu-devel] [PATCH for-2.11? v7 6/6] tests: Add check-qobject for equality tests,
Eric Blake <=
- [Qemu-devel] [PATCH for-2.11? v7 3/6] qapi: Add qobject_is_equal(), Max Reitz, 2017/11/14
- Re: [Qemu-devel] [PATCH for-2.11? v7 0/6] block: Don't compare strings in bdrv_reopen_prepare(), Eric Blake, 2017/11/14
- Re: [Qemu-devel] [PATCH for-2.11? v7 0/6] block: Don't compare strings in bdrv_reopen_prepare(), Max Reitz, 2017/11/14