[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reo
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare() |
Date: |
Tue, 14 Nov 2017 16:48:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 2017-10-04 17:25, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
>
>
> v6:
> - Patch 2: Added corresponding Coccinelle rule [Eric]
> - Patch 6:
> - Added .gitignore entry [Eric]
> - Removed leading underscore [Markus]
> - Replaced test_equality() by check_equal()+check_unequal() [Markus]
> - Put type conversion (or rather non-conversion) tests into an own
> function [Markus]
> - Fixed a line > 80 characters
Dropping from my queue because of a clang compiler warning in
tests/check-qobject.c.
Max
signature.asc
Description: OpenPGP digital signature