[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async event
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events |
Date: |
Tue, 14 Nov 2017 14:34:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 14/11/2017 09:16, Pavel Dovgalyuk wrote:
> Asynchronous events saved at checkpoints may invoke
> callbacks when processed. These callbacks may also generate/read
> new events (e.g. clock reads). Therefore event processing flag must be
> reset before callback invocation.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> ---
> replay/replay-events.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index 94a6dcc..768b505 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -295,13 +295,13 @@ void replay_read_events(int checkpoint)
> if (!event) {
> break;
> }
> + replay_finish_event();
> + read_event_kind = -1;
> replay_mutex_unlock();
> replay_run_event(event);
> replay_mutex_lock();
>
> g_free(event);
> - replay_finish_event();
> - read_event_kind = -1;
> }
> }
>
>
For 2.11
Acked-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [RFC PATCH v2 00/26] replay additions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 00/26] replay additions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 01/26] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 02/26] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 03/26] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 06/26] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 07/26] replay: added replay log format description, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/11/14