[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified Connection |
Date: |
Tue, 14 Nov 2017 10:11:33 +0800 |
From: Mao Zhongyi <address@hidden>
A package from pri_indev or sec_indev only belongs to a particular
Connection, so we only need to compare the package in the specified
Connection's primary_list and secondary_list, rather than for each
the whole Connection list to compare. This is time-consuming and
unnecessary.
Less checkpoint more efficiency.
Cc: Zhang Chen <address@hidden>
Cc: Li Zhijian <address@hidden>
Cc: Jason Wang <address@hidden>
Signed-off-by: Mao Zhongyi <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
net/colo-compare.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 54b6347..5d2429b 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -136,7 +136,7 @@ static int colo_insert_packet(GQueue *queue, Packet *pkt)
* Return 0 on success, if return -1 means the pkt
* is unsupported(arp and ipv6) and will be sent later
*/
-static int packet_enqueue(CompareState *s, int mode)
+static int packet_enqueue(CompareState *s, int mode, Connection **con)
{
ConnectionKey key;
Packet *pkt = NULL;
@@ -179,6 +179,7 @@ static int packet_enqueue(CompareState *s, int mode)
"drop packet");
}
}
+ con = &conn;
return 0;
}
@@ -728,8 +729,9 @@ static void compare_set_vnet_hdr(Object *obj,
static void compare_pri_rs_finalize(SocketReadState *pri_rs)
{
CompareState *s = container_of(pri_rs, CompareState, pri_rs);
+ Connection *conn = NULL;
- if (packet_enqueue(s, PRIMARY_IN)) {
+ if (packet_enqueue(s, PRIMARY_IN, &conn)) {
trace_colo_compare_main("primary: unsupported packet in");
compare_chr_send(s,
pri_rs->buf,
@@ -737,19 +739,20 @@ static void compare_pri_rs_finalize(SocketReadState
*pri_rs)
pri_rs->vnet_hdr_len);
} else {
/* compare connection */
- g_queue_foreach(&s->conn_list, colo_compare_connection, s);
+ colo_compare_connection(conn, s);
}
}
static void compare_sec_rs_finalize(SocketReadState *sec_rs)
{
CompareState *s = container_of(sec_rs, CompareState, sec_rs);
+ Connection *conn = NULL;
- if (packet_enqueue(s, SECONDARY_IN)) {
+ if (packet_enqueue(s, SECONDARY_IN, &conn)) {
trace_colo_compare_main("secondary: unsupported packet in");
} else {
/* compare connection */
- g_queue_foreach(&s->conn_list, colo_compare_connection, s);
+ colo_compare_connection(conn, s);
}
}
--
2.7.4
- [Qemu-devel] [PULL 0/8] Net patches, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 1/8] net: fix check for number of parameters to -netdev socket, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 2/8] colo-compare: Insert packet into the suitable position of packet queue directly, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified Connection,
Jason Wang <=
- [Qemu-devel] [PULL 4/8] colo-compare: Fix comments, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 6/8] Fix eepro100 simple transmission mode, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 5/8] colo: Consolidate the duplicate code chunk into a routine, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a, Jason Wang, 2017/11/13
- [Qemu-devel] [PULL 8/8] net/socket: fix coverity issue, Jason Wang, 2017/11/13
- Re: [Qemu-devel] [PULL 0/8] Net patches, Peter Maydell, 2017/11/14