[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 3/8] qemu.py: refactor launch()
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v9 3/8] qemu.py: refactor launch() |
Date: |
Mon, 13 Nov 2017 22:39:40 +0100 |
This is just an refactor to separate the exception handler from the
actual launch procedure, improving the readability and making future
maintenances in this piece of code easier.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 58f00bdd64..8a1c97d964 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -192,20 +192,14 @@ class QEMUMachine(object):
self._temp_dir = None
def launch(self):
- '''Launch the VM and establish a QMP connection'''
+ """
+ Launch the VM and make sure we cleanup and expose the
+ command line/output in case of exception
+ """
self._iolog = None
self._qemu_full_args = None
- devnull = open(os.path.devnull, 'rb')
try:
- self._pre_launch()
- self._qemu_full_args = (self._wrapper + [self._binary] +
- self._base_args() + self._args)
- self._popen = subprocess.Popen(self._qemu_full_args,
- stdin=devnull,
- stdout=self._qemu_log_fd,
- stderr=subprocess.STDOUT,
- shell=False)
- self._post_launch()
+ self._launch()
except:
if self.is_running():
self._popen.kill()
@@ -220,6 +214,19 @@ class QEMUMachine(object):
LOG.debug('Output: %r', self._iolog)
raise
+ def _launch(self):
+ '''Launch the VM and establish a QMP connection'''
+ devnull = open(os.path.devnull, 'rb')
+ self._pre_launch()
+ self._qemu_full_args = (self._wrapper + [self._binary] +
+ self._base_args() + self._args)
+ self._popen = subprocess.Popen(self._qemu_full_args,
+ stdin=devnull,
+ stdout=self._qemu_log_fd,
+ stderr=subprocess.STDOUT,
+ shell=False)
+ self._post_launch()
+
def wait(self):
'''Wait for the VM to power off'''
self._popen.wait()
--
2.13.6
- [Qemu-devel] [PATCH v9 0/8] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 1/8] qemu.py: remove unused import, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 3/8] qemu.py: refactor launch(),
Amador Pahim <=
- [Qemu-devel] [PATCH v9 4/8] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 5/8] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 6/8] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 7/8] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v9 8/8] qemu.py: don't launch again before shutdown(), Amador Pahim, 2017/11/13
- Re: [Qemu-devel] [PATCH v9 0/8] scripts/qemu.py fixes and cleanups, no-reply, 2017/11/14