[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotests: 077: Filter out 'resume' lines
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] iotests: 077: Filter out 'resume' lines |
Date: |
Mon, 13 Nov 2017 09:37:33 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/13/2017 09:00 AM, Fam Zheng wrote:
> In the "Overlapping multiple requests" cases, the 3rd reqs (the break
> point B) doesn't wait for the 2nd, and once resumed the I/O will just
> continue. This is because the 2nd is already waiting for the 1st, and
> in wait_serialising_requests() there is:
>
> Filter out the "Resuming request" lines to make the output
> deterministic.
>
> Reported-by: Patchew <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/077 | 3 ++-
> tests/qemu-iotests/077.out | 48
> ++++++++++++++++------------------------------
> 2 files changed, 18 insertions(+), 33 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> @@ -4,17 +4,6 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
> == Some concurrent requests involving RMW ==
> wrote XXX/XXX bytes at offset XXX
> XXX bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -blkdebug: Resuming request 'A'
> -wrote XXX/XXX bytes at offset XXX
> -XXX bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -wrote XXX/XXX bytes at offset XXX
> -XXX bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -blkdebug: Resuming request 'A'
> -wrote XXX/XXX bytes at offset XXX
> -XXX bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -wrote XXX/XXX bytes at offset XXX
> -XXX bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -blkdebug: Resuming request 'A'
git diff does a really lousy job of displaying this one, but the end
result looks correct.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature