[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removabl
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media |
Date: |
Fri, 10 Nov 2017 23:21:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 2017-11-10 19:54, Alberto Garcia wrote:
> This test hotplugs a CD drive to a VM and checks that I/O limits can
> be set only when the drive has media inserted and that they are kept
> when the media is replaced.
>
> This also tests the removal of a device with valid I/O limits set but
> no media inserted. This involves deleting and disabling the limits
> of a BlockBackend without BlockDriverState, a scenario that has been
> crashing until the fixes from the last couple of patches.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> tests/qemu-iotests/093 | 62
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/093.out | 4 +--
> 2 files changed, 64 insertions(+), 2 deletions(-)
By the way, I just noticed that this test tests that
x-blockdev-remove-medium and x-blockdev-insert-medium do not destroy
throttling information -- which is exactly why those commands had been
declared experimental in the first place. So I guess this means we can
drop the x- now. :-)
Max
signature.asc
Description: OpenPGP digital signature