[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when drai
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS |
Date: |
Fri, 10 Nov 2017 23:31:03 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, 11/10 16:23, Max Reitz wrote:
> But bdrv_unref() is safe only in the main loop. Without having checked,
> I'm not sure whether all callers of bdrv_next() are running in the main
> loop.
They must be. The reasoning is simple:
1) one needs to acquire the ctx of all the BDSes for safe access;
2) only main loop can acquire any BDS' ctx;
So there is no way bdrv_next can work in an IOThread.
Fam
- [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Max Reitz, 2017/11/09
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Eric Blake, 2017/11/09
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Fam Zheng, 2017/11/09
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Kevin Wolf, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Fam Zheng, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Max Reitz, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Kevin Wolf, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Max Reitz, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Kevin Wolf, 2017/11/10
- Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Max Reitz, 2017/11/10
Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS, Stefan Hajnoczi, 2017/11/10