qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread


From: Fam Zheng
Subject: Re: [Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread
Date: Wed, 8 Nov 2017 19:16:03 +0800
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, 11/08 15:31, Peter Xu wrote:
> On Tue, Nov 07, 2017 at 03:57:08PM +0800, Fam Zheng wrote:
> > On Mon, 11/06 17:46, Peter Xu wrote:
> > > @@ -4294,6 +4366,11 @@ static GMainContext *monitor_io_context_get(void)
> > >      return iothread_get_g_main_context(mon_global.mon_iothread);
> > >  }
> > >  
> > > +static AioContext *monitor_aio_context_get(void)
> > > +{
> > > +    return iothread_get_aio_context(mon_global.mon_iothread);
> > > +}
> > > +
> > 
> > This hunk fits better in patch 10, I think?
> 
> This function is only used in current patch, so I think it's fine to
> put it here.  But sure I can move it into patch 10 as well.

OK, so it's static and you want to keep the compiler happy. That's fine then.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]