[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Make scrolling work again
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] Make scrolling work again |
Date: |
Tue, 7 Nov 2017 10:08:36 +0000 |
On 1 November 2017 at 15:46, John Arbuckle <address@hidden> wrote:
> Make scrolling in the monitor work.
>
> Signed-off-by: John Arbuckle <address@hidden>
> ---
> ui/cocoa.m | 96
> +++++++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 64 insertions(+), 32 deletions(-)
Hi; I've applied this to my cocoa.next branch.
I tweaked the commit message a bit (subject lines
ought to have some kind of prefix like "ui/cocoa"
to indicate what area of QEMU they relate to -- this
commit message didn't have anything saying it was
Cocoa related at all.
> +
> + // if not a key that needs translating
> + if (keysym == 0) {
> + NSString *ks = [event characters];
> + if ([ks length] > 0)
> + keysym = [ks characterAtIndex:0];
> + }
> +
> + if (keysym)
> + kbd_put_keysym(keysym);
I did ask you to put braces on these if statements;
I've fixed that up in the version I applied to cocoa.next.
thanks
-- PMM