Re: [Qemu-devel] [PATCH] linux-user: remove nmi.c and fw-path-provider.c

[Alexey Kardashevskiy]

On 04/11/17 06:38, Laurent Vivier wrote:
> linux-user binaries don't need firmware and NMI,
> so don't add them in this case, move QDEV
> firmware functions to qdev-fw.c


When configured with --target-list=ppc64-linux-user , config-host.mak gets
TARGET_DIRS=ppc64-linux-user  and I would expect CONFIG_SOFTMMU to be
disabled in Makefile#27 and qdev.c not to be compiled at all but this is
not happening, I wonder why...


> 
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  hw/core/Makefile.objs |  5 +--
>  hw/core/qdev-fw.c     | 96 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/core/qdev.c        | 77 -----------------------------------------
>  3 files changed, 99 insertions(+), 79 deletions(-)
>  create mode 100644 hw/core/qdev-fw.c
> 
> diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
> index f8d7a4aaed..1240728c87 100644
> --- a/hw/core/Makefile.objs
> +++ b/hw/core/Makefile.objs
> @@ -1,11 +1,12 @@
>  # core qdev-related obj files, also used by *-user:
>  common-obj-y += qdev.o qdev-properties.o
>  common-obj-y += bus.o reset.o
> -common-obj-y += fw-path-provider.o
> +common-obj-$(CONFIG_SOFTMMU) += qdev-fw.o
> +common-obj-$(CONFIG_SOFTMMU) += fw-path-provider.o
>  # irq.o needed for qdev GPIO handling:
>  common-obj-y += irq.o
>  common-obj-y += hotplug.o
> -common-obj-y += nmi.o
> +common-obj-$(CONFIG_SOFTMMU) += nmi.o
>  
>  common-obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o
>  common-obj-$(CONFIG_XILINX_AXI) += stream.o



-- 
Alexey