[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of replay_lock |
Date: |
Tue, 31 Oct 2017 13:49:02 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Alex Bennée <address@hidden>
This is modelled after the iothread mutex lock. We keep a TLS flag to
indicate when that thread has acquired the lock and assert we don't
double-lock or release when we shouldn't have.
Signed-off-by: Alex Bennée <address@hidden>
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-internal.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index fca8514..157c863 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -179,13 +179,24 @@ void replay_mutex_destroy(void)
qemu_mutex_destroy(&lock);
}
+static __thread bool replay_locked;
+
+static bool replay_mutex_locked(void)
+{
+ return replay_locked;
+}
+
void replay_mutex_lock(void)
{
+ g_assert(!replay_mutex_locked());
qemu_mutex_lock(&lock);
+ replay_locked = true;
}
void replay_mutex_unlock(void)
{
+ g_assert(replay_mutex_locked());
+ replay_locked = false;
qemu_mutex_unlock(&lock);
}
- Re: [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue, (continued)
- [Qemu-devel] [RFCPATCH05/20] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH07/20] replay: added replay log format description, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH09/20] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH11/20] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH12/20] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH13/20] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH14/20] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of replay_lock,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFCPATCH16/20] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH17/20] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH18/20] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH19/20] cpu-exec: reset exit flag before calling cpu_exec_nocache, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH20/20] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2017/10/31