[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/12] nbd/client: refactor nbd_receive_starttls
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 09/12] nbd/client: refactor nbd_receive_starttls |
Date: |
Mon, 30 Oct 2017 21:56:33 +0100 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
Split out nbd_request_simple_option to be reused for structured reply
option.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
---
nbd/client.c | 70 ++++++++++++++++++++++++++++++++++++++------------------
nbd/trace-events | 4 +---
2 files changed, 49 insertions(+), 25 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index 50f36b511e..9acf745b79 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -508,35 +508,61 @@ static int nbd_receive_query_exports(QIOChannel *ioc,
}
}
+/* nbd_request_simple_option: Send an option request, and parse the reply
+ * return 1 for successful negotiation,
+ * 0 if operation is unsupported,
+ * -1 with errp set for any other error
+ */
+static int nbd_request_simple_option(QIOChannel *ioc, int opt, Error **errp)
+{
+ nbd_opt_reply reply;
+ int error;
+
+ if (nbd_send_option_request(ioc, opt, 0, NULL, errp) < 0) {
+ return -1;
+ }
+
+ if (nbd_receive_option_reply(ioc, opt, &reply, errp) < 0) {
+ return -1;
+ }
+ error = nbd_handle_reply_err(ioc, &reply, errp);
+ if (error <= 0) {
+ return error;
+ }
+
+ if (reply.type != NBD_REP_ACK) {
+ error_setg(errp, "Server answered option %d (%s) with unexpected "
+ "reply %" PRIx32 " (%s)", opt, nbd_opt_lookup(opt),
+ reply.type, nbd_rep_lookup(reply.type));
+ nbd_send_opt_abort(ioc);
+ return -1;
+ }
+
+ if (reply.length != 0) {
+ error_setg(errp, "Option %d ('%s') response length is %" PRIu32
+ " (it should be zero)", opt, nbd_opt_lookup(opt),
+ reply.length);
+ nbd_send_opt_abort(ioc);
+ return -1;
+ }
+
+ return 1;
+}
+
static QIOChannel *nbd_receive_starttls(QIOChannel *ioc,
QCryptoTLSCreds *tlscreds,
const char *hostname, Error **errp)
{
- nbd_opt_reply reply;
+ int ret;
QIOChannelTLS *tioc;
struct NBDTLSHandshakeData data = { 0 };
- trace_nbd_receive_starttls_request();
- if (nbd_send_option_request(ioc, NBD_OPT_STARTTLS, 0, NULL, errp) < 0) {
- return NULL;
- }
-
- trace_nbd_receive_starttls_reply();
- if (nbd_receive_option_reply(ioc, NBD_OPT_STARTTLS, &reply, errp) < 0) {
- return NULL;
- }
-
- if (reply.type != NBD_REP_ACK) {
- error_setg(errp, "Server rejected request to start TLS %" PRIx32,
- reply.type);
- nbd_send_opt_abort(ioc);
- return NULL;
- }
-
- if (reply.length != 0) {
- error_setg(errp, "Start TLS response was not zero %" PRIu32,
- reply.length);
- nbd_send_opt_abort(ioc);
+ ret = nbd_request_simple_option(ioc, NBD_OPT_STARTTLS, errp);
+ if (ret <= 0) {
+ if (ret == 0) {
+ error_setg(errp, "Server don't support STARTTLS option");
+ nbd_send_opt_abort(ioc);
+ }
return NULL;
}
diff --git a/nbd/trace-events b/nbd/trace-events
index 52150bd738..596df96575 100644
--- a/nbd/trace-events
+++ b/nbd/trace-events
@@ -8,9 +8,7 @@ nbd_opt_go_info_unknown(int info, const char *name) "Ignoring
unknown info %d (%
nbd_opt_go_info_block_size(uint32_t minimum, uint32_t preferred, uint32_t
maximum) "Block sizes are 0x%" PRIx32 ", 0x%" PRIx32 ", 0x%" PRIx32
nbd_receive_query_exports_start(const char *wantname) "Querying export list
for '%s'"
nbd_receive_query_exports_success(const char *wantname) "Found desired export
name '%s'"
-nbd_receive_starttls_request(void) "Requesting TLS from server"
-nbd_receive_starttls_reply(void) "Getting TLS reply from server"
-nbd_receive_starttls_new_client(void) "TLS request approved, setting up TLS"
+nbd_receive_starttls_new_client(void) "Setting up TLS"
nbd_receive_starttls_tls_handshake(void) "Starting TLS handshake"
nbd_receive_negotiate(void *tlscreds, const char *hostname) "Receiving
negotiation tlscreds=%p hostname=%s"
nbd_receive_negotiate_magic(uint64_t magic) "Magic is 0x%" PRIx64
--
2.13.6
- [Qemu-devel] [PULL 00/12] NBD patches prior to 2.11 soft freeze, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 01/12] nbd: Include error names in trace messages, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 02/12] nbd: Move nbd_errno_to_system_errno() to public header, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 04/12] nbd/server: Report error for write to read-only export, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 03/12] nbd: Expose constants and structs for structured read, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 05/12] nbd/server: Simplify nbd_negotiate_options loop, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 06/12] nbd/server: Refactor zero-length option check, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 07/12] nbd: Minimal structured read for server, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 08/12] nbd/server: Include human-readable message in structured errors, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 09/12] nbd/client: refactor nbd_receive_starttls,
Eric Blake <=
- [Qemu-devel] [PULL 10/12] nbd/client: prepare nbd_receive_reply for structured reply, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 11/12] nbd: Move nbd_read() to common header, Eric Blake, 2017/10/30
- [Qemu-devel] [PULL 12/12] nbd: Minimal structured read for client, Eric Blake, 2017/10/30
- Re: [Qemu-devel] [PULL 00/12] NBD patches prior to 2.11 soft freeze, Peter Maydell, 2017/10/31