[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vga: fix region checks in wraparound case
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] vga: fix region checks in wraparound case |
Date: |
Mon, 30 Oct 2017 15:05:57 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Gerd Hoffmann (address@hidden) wrote:
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Makes more sense to me;
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/display/vga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/vga.c b/hw/display/vga.c
> index 1d19f6b..a64a094 100644
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -1666,9 +1666,9 @@ static void vga_draw_graphic(VGACommonState *s, int
> full_update)
> /* scanline wraps from end of video memory to the start */
> assert(force_shadow);
> update = memory_region_snapshot_get_dirty(&s->vram, snap,
> - page0, 0);
> + page0, s->vbe_size -
> page0);
> update |= memory_region_snapshot_get_dirty(&s->vram, snap,
> - page1, 0);
> + 0, page1);
> } else {
> update = memory_region_snapshot_get_dirty(&s->vram, snap,
> page0, page1 - page0);
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK