[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target/ppc: Use tcg_gen_lookup_and_goto_ptr
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2] target/ppc: Use tcg_gen_lookup_and_goto_ptr |
Date: |
Fri, 27 Oct 2017 23:45:42 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Oct 27, 2017 at 06:58:14PM +0200, Richard Henderson wrote:
> From: Richard Henderson <address@hidden>
>
> Signed-off-by: Richard Henderson <address@hidden>
Applied,thanks.
> ---
> Rebased and updated for changes to tcg_gen_lookup_and_goto_ptr.
>
> ---
> target/ppc/translate.c | 23 ++++++++---------------
> 1 file changed, 8 insertions(+), 15 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 998fbed848..4075fc8589 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -3419,7 +3419,7 @@ static inline bool use_goto_tb(DisasContext *ctx,
> target_ulong dest)
> }
>
> /*** Branch
> ***/
> -static inline void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
> +static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
> {
> if (NARROW_MODE(ctx)) {
> dest = (uint32_t) dest;
> @@ -3441,7 +3441,7 @@ static inline void gen_goto_tb(DisasContext *ctx, int
> n, target_ulong dest)
> gen_debug_exception(ctx);
> }
> }
> - tcg_gen_exit_tb(0);
> + tcg_gen_lookup_and_goto_ptr();
> }
> }
>
> @@ -3479,7 +3479,7 @@ static void gen_b(DisasContext *ctx)
> #define BCOND_CTR 2
> #define BCOND_TAR 3
>
> -static inline void gen_bcond(DisasContext *ctx, int type)
> +static void gen_bcond(DisasContext *ctx, int type)
> {
> uint32_t bo = BO(ctx->opcode);
> TCGLabel *l1;
> @@ -3543,26 +3543,19 @@ static inline void gen_bcond(DisasContext *ctx, int
> type)
> } else {
> gen_goto_tb(ctx, 0, li);
> }
> - if ((bo & 0x14) != 0x14) {
> - gen_set_label(l1);
> - gen_goto_tb(ctx, 1, ctx->nip);
> - }
> } else {
> if (NARROW_MODE(ctx)) {
> tcg_gen_andi_tl(cpu_nip, target, (uint32_t)~3);
> } else {
> tcg_gen_andi_tl(cpu_nip, target, ~3);
> }
> - tcg_gen_exit_tb(0);
> - if ((bo & 0x14) != 0x14) {
> - gen_set_label(l1);
> - gen_update_nip(ctx, ctx->nip);
> - tcg_gen_exit_tb(0);
> - }
> - }
> - if (type == BCOND_LR || type == BCOND_CTR || type == BCOND_TAR) {
> + tcg_gen_lookup_and_goto_ptr();
> tcg_temp_free(target);
> }
> + if ((bo & 0x14) != 0x14) {
> + gen_set_label(l1);
> + gen_goto_tb(ctx, 1, ctx->nip);
> + }
> }
>
> static void gen_bc(DisasContext *ctx)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature