[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read |
Date: |
Fri, 27 Oct 2017 16:59:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 10/27/2017 12:59 PM, address@hidden wrote:
> Hi,
>
> This series failed build test on ppc host. Please find the details below.
>
> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c: In function
> ‘nbd_co_client_start’:
> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c:819:12: error: ‘ret’
> may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (ret < 0) {
> ^
> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c:647:13: note: ‘ret’ was
> declared here
> int ret;
> ^
Real bug when reporting success on NBD_OPT_STARTTLS.
This should fix it; I'll squash it into the right place in the series.
diff --git i/nbd/server.c w/nbd/server.c
index ea9fe9970f..2b617f3cd1 100644
--- i/nbd/server.c
+++ w/nbd/server.c
@@ -693,6 +693,7 @@ static int nbd_negotiate_options(NBDClient *client,
uint16_t myflags,
if (!tioc) {
return -EIO;
}
+ ret = 0;
object_unref(OBJECT(client->ioc));
client->ioc = QIO_CHANNEL(tioc);
break;
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 04/12] nbd/server: Report error for write to read-only export, (continued)
- [Qemu-devel] [PATCH v6 04/12] nbd/server: Report error for write to read-only export, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 08/12] nbd/server: Include human-readable message in structured errors, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 07/12] nbd: Minimal structured read for server, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 09/12] nbd/client: refactor nbd_receive_starttls, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 10/12] nbd/client: prepare nbd_receive_reply for structured reply, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 11/12] nbd: Move nbd_read() to common header, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 12/12] nbd: Minimal structured read for client, Eric Blake, 2017/10/27
- [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity, Eric Blake, 2017/10/27
- Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read, no-reply, 2017/10/27
- Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read,
Eric Blake <=