[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache |
|
Date: |
Thu, 26 Oct 2017 13:37:55 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
> > * Juan Quintela (address@hidden) wrote:
> >> After the previous commits, we make sure that the value passed is
> >> right, or we just drop an error. So now we return if there is one
> >> error or we have setup correctly the value passed.
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
>
> > OK, this shares the same oddity as the original which is
> > XBZRLE.cache = NULL is not an error.
> >
> > but, since that is the same as the original;
>
> Hi
>
> It is a normal case. You can change the cache size in the middle of
> migration or outside migration.
>
> If we are not in the middle of migration, cache is NULL.
Ah OK, so yes,
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Later, Juan.
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK