Re: [Qemu-devel] [PATCH] ACPI/unit-test: Add a testcase for RAM allocation in numa node

[Dou Liyang]

Hi Eduardo,

Thanks for your reply.

At 10/21/2017 03:15 AM, Eduardo Habkost wrote:
> On Wed, Oct 18, 2017 at 11:50:32AM +0800, Dou Liyang wrote:
> > At 10/18/2017 11:48 AM, Dou Liyang wrote:
> > > As QEMU supports the memory-less node, it is possible that there is
> > > no RAM in the first numa node(also be called as node0). eg:
> > >   ... \
> > >   -m 128,slots=3,maxmem=1G \
> > >   -numa node -numa node,mem=128M \
> > >
> > > But, this makes it hard for QEMU to build a known-to-work ACPI SRAT
> > > table. Only fixing it is not enough.
> > >
> > > Add a testcase for this situation to make sure the ACPI table is
> > > correct for guest.
> > >
> > > Suggested-by: Eduardo Habkost <address@hidden>
> > > Signed-off-by: Dou Liyang <address@hidden>
> > > ---
> > > Changelog:
> > >
> > > This patch can pass the 'make check' in Peter's machine,
> >
> > Oops,  s/can/can not  :-).
> >
> > Thanks,
> >         dou.
> >
> > > But, in my own and Eduardo's machine, we can pass it.
> > >
> > > So I rebase and spilt it independently.
>
> Thanks!
>
> > > Peter:
> > >
> > > could you help me test it in your machine.
> > > then, give me the output files, such as /tmp/asl-6QYK7Y.dsl and 
> > > /tmp/asl-1H1I7Y.dsl file.
>
> As the failures reported by Peter were about the *.memhp test
> case files, I think this patch is unlikely to be the cause of
> those failures.  I believe the problem is at:
>
>   From: Dou Liyang <address@hidden>
>   Date: Fri, 1 Sep 2017 10:10:03 +0800
>   Message-ID: <address@hidden>
>   Subject: [PATCH v6 2/4] hw/acpi-build: Make assignment statement
>            of next_base easy to read

This patch is just used for readability. so I discard it. and, we
need a test case for the commit

  4926403c250f ("hw/acpi-build: Fix SRAT memory building in case of 
node 0 without RAM")

So, I re-post this patch. ;-)


> However, I would still like to get test results from Peter before
> applying this patch again.

I see.

Thanks,
        dou