[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler |
Date: |
Sat, 21 Oct 2017 17:59:26 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
adfd619816 disas: Add capstone as submodule
8416b988cb disas: Remove monitor_disas_is_physical
090b0922de ppc: Support Capstone in disas_set_info
c699ea3330 arm: Support Capstone in disas_set_info
3058468c0b i386: Support Capstone in disas_set_info
f699eb2a5f disas: Support the Capstone disassembler library
15be206a49 disas: Remove unused flags arguments
0302e51e27 target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY
b7cb940bef target/arm: Move BE32 disassembler fixup
25f16216ab target/ppc: Convert to disas_set_info hook
469a65d2ec target/i386: Convert to disas_set_info hook
=== OUTPUT BEGIN ===
Checking PATCH 1/11: target/i386: Convert to disas_set_info hook...
Checking PATCH 2/11: target/ppc: Convert to disas_set_info hook...
Checking PATCH 3/11: target/arm: Move BE32 disassembler fixup...
ERROR: space prohibited between function name and open parenthesis '('
#42: FILE: disas/arm.c:3824:
+ status = arm_read_memory (addr, (bfd_byte *)b, 2, info);
ERROR: space prohibited between function name and open parenthesis '('
#51: FILE: disas/arm.c:3896:
+ status = arm_read_memory (pc, (bfd_byte *)b, size, info);
ERROR: space prohibited between function name and open parenthesis '('
#60: FILE: disas/arm.c:3913:
+ status = arm_read_memory (pc, (bfd_byte *)b, 4, info);
ERROR: space prohibited between function name and open parenthesis '('
#69: FILE: disas/arm.c:3929:
+ status = arm_read_memory (pc, (bfd_byte *)b, 2, info);
ERROR: code indent should never use tabs
#78: FILE: disas/arm.c:3943:
+^I status = arm_read_memory (pc + 2, (bfd_byte *)b, 2, info);$
ERROR: space prohibited between function name and open parenthesis '('
#78: FILE: disas/arm.c:3943:
+ status = arm_read_memory (pc + 2, (bfd_byte *)b, 2, info);
total: 6 errors, 0 warnings, 107 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/11: target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY...
Checking PATCH 5/11: disas: Remove unused flags arguments...
Checking PATCH 6/11: disas: Support the Capstone disassembler library...
Checking PATCH 7/11: i386: Support Capstone in disas_set_info...
Checking PATCH 8/11: arm: Support Capstone in disas_set_info...
Checking PATCH 9/11: ppc: Support Capstone in disas_set_info...
Checking PATCH 10/11: disas: Remove monitor_disas_is_physical...
Checking PATCH 11/11: disas: Add capstone as submodule...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v7 06/11] disas: Support the Capstone disassembler library, (continued)
- [Qemu-devel] [PATCH v7 06/11] disas: Support the Capstone disassembler library, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 07/11] i386: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 08/11] arm: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 09/11] ppc: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 10/11] disas: Remove monitor_disas_is_physical, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule, Richard Henderson, 2017/10/21
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler,
no-reply <=
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler, no-reply, 2017/10/21
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler, no-reply, 2017/10/21