[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device |
Date: |
Thu, 19 Oct 2017 18:39:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/15/2017 09:27 AM, Cornelia Huck wrote:
>>>
>>>> + DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type,
>>>> + 0x98),
> This might also need re-evaluation - we should not really need a new
> chpid type.
>
I'm back at ccw-tester again (for v2). I've realized we did not agree
on what to use here (chpid_type). Shall I use 0x25 (Fibre Channel) or
EMULATED_CCW_3270_CHPID_TYPE, or even 0x32 (virtio-ccw) as a default
value? And should EMULATED_CCW_3270_CHPID_TYPE be called like that
(is it really supposed to be specific to 3270?
Sorry I did not notice sooner.
Regards,
Halil
- Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device,
Halil Pasic <=