[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimi
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimize |
|
Date: |
Tue, 17 Oct 2017 18:16:29 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 16, 2017 at 10:25:33 -0700, Richard Henderson wrote:
> From: Richard Henderson <address@hidden>
>
> While we're touching many of the lines anyway, adjust the naming
> of the functions to better distinguish when "TCGArg" vs "TCGTemp"
> should be used.
>
> Signed-off-by: Richard Henderson <address@hidden>
(snip)
> -static struct tcg_temp_info temps[TCG_MAX_TEMPS];
> +static struct tcg_temp_info temps_[TCG_MAX_TEMPS];
Is this rename really necessary?
The rest looks good:
Reviewed-by: Emilio G. Cota <address@hidden>
E.
- Re: [Qemu-devel] [PATCH v6 15/50] tcg: Push tcg_ctx into generator functions, (continued)
- [Qemu-devel] [PATCH v6 16/50] tcg: Push tcg_ctx into tcg_gen_callN, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 18/50] tcg: Reserve temporary index 0, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 17/50] tcg: Introduce index_arg, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 19/50] target/alpha: Avoid translate_init unless tcg_enabled, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimize, Richard Henderson, 2017/10/16
- Re: [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimize,
Emilio G. Cota <=
- [Qemu-devel] [PATCH v6 21/50] tcg: Use pointers in TCGOp->args, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 23/50] hack dump tb->flags and tb->cflags, Richard Henderson, 2017/10/16