Re: [Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in optimizer

[Emilio G. Cota]

On Mon, Oct 16, 2017 at 10:25:21 -0700, Richard Henderson wrote:
> From: Richard Henderson <address@hidden>
> 
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  tcg/optimize.c | 430 
> ++++++++++++++++++++++++++++++---------------------------
(snip)
> @@ -559,7 +557,7 @@ static bool swap_commutative2(TCGArg *p1, TCGArg *p2)
>  void tcg_optimize(TCGContext *s)
>  {
>      int oi, oi_next, nb_temps, nb_globals;
> -    TCGArg *prev_mb_args = NULL;
> +    TCGOp *prev_mb = NULL;
>  
>      /* Array VALS has an element for each temp.
>         If this temp holds a constant then its value is kept in VALS' element.
> @@ -576,7 +574,6 @@ void tcg_optimize(TCGContext *s)
>          TCGArg tmp;
>  
>          TCGOp * const op = &s->gen_op_buf[oi];
> -        TCGArg * const args = op->args;

Reviewed-by: Emilio G. Cota <address@hidden>

Just for my own education: why doesn't gcc generate the same code when
leaving 'args' as above? I thought we could simplify the diff without
any side effects, but it turns out that more code is generated.

Thanks,

                E.