Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument

[Michael S. Tsirkin]

On Mon, Oct 16, 2017 at 06:03:36PM +0200, address@hidden wrote:
> From: Lukas Humbel <address@hidden>
> 
> Signed-off-by: Lukas Humbel <address@hidden>

We keep these around for legacy reasons but I'm not sure we need to add
to the list.  What's wrong with just creating them with -device e1000e?

> ---
>  hw/pci/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 1e6fb88..9d6cd04 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000e",
>      "pcnet",
>      "virtio",
>      "sungem",
> @@ -1832,6 +1833,7 @@ static const char * const pci_nic_names[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000e",
>      "pcnet",
>      "virtio-net-pci",
>      "sungem",
> -- 
> 2.7.4