[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small clea
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups) |
Date: |
Mon, 16 Oct 2017 18:20:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 16/10/2017 16:42, David Hildenbrand wrote:
> Hopefully this is the last bunch of fixes for the cleanup series.
>
> 1. log_start() was called before region_add(), which is wrong.
> 2. I messed up the calculation of the delta when aligning the ram address
> (maybe we should simply also use ROUND_UP there ...).
> 3. I think we could get log_start/log_stop/log_sync when we actually
> haven't registered a slot (due to trapping).
> 4. Some further cleanups
>
> Available on: https://github.com/davidhildenbrand/qemu/commits/kvm_slot
>
> @Joe, if you could retest, this would be great! I updated the branch.
>
> David Hildenbrand (7):
> memory: call log_start after region_add
> kvm: fix alignment of ram address
> kvm: tolerate non-existing slot for log_start/log_stop/log_sync
> kvm: fix error message when failing to unregister slot
> kvm: region_add and region_del is not called on updates
> kvm: simplify kvm_align_section()
> memory: reuse section_from_flat_range()
>
> accel/kvm/kvm-all.c | 39 ++++++++++++++-------------------------
> memory.c | 16 +++++-----------
> 2 files changed, 19 insertions(+), 36 deletions(-)
>
Looks good! I'll wait for testing results if they come soon.
Paolo
- [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups), David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 2/7] kvm: fix alignment of ram address, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 3/7] kvm: tolerate non-existing slot for log_start/log_stop/log_sync, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 1/7] memory: call log_start after region_add, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 4/7] kvm: fix error message when failing to unregister slot, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called on updates, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 6/7] kvm: simplify kvm_align_section(), David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 7/7] memory: reuse section_from_flat_range(), David Hildenbrand, 2017/10/16
- Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups),
Paolo Bonzini <=