Re: [Qemu-devel] [PATCH v1] memory: call log_start after region_add

[David Hildenbrand]

On 16.10.2017 14:19, Paolo Bonzini wrote:
> On 16/10/2017 11:36, David Hildenbrand wrote:
>>> -        if (fr->dirty_log_mask && listener->log_start) {
>>> -            listener->log_start(listener, &section, 0, fr->dirty_log_mask);
>>> -        }
>>>          if (listener->region_add) {
>>>              listener->region_add(listener, &section);
>>>          }
>>> +        if (fr->dirty_log_mask && listener->log_start) {
>>> +            listener->log_start(listener, &section, 0, fr->dirty_log_mask);
>>> +        }
>>>      }
>>>      if (listener->commit) {
>>>          listener->commit(listener);
>>>
>> ... deciding to tolerate it in KVM instead (just as it used to be), so
>> please ignore this patch.
> 
> Why?  It makes no sense to start logging on a non-existent region, and
> this behavior is unique to listener_add_address_space.

As you requested, will add everything into one patch series and send out
for review.

Thanks!

-- 

Thanks,

David